opentelemetry-erlang-contrib icon indicating copy to clipboard operation
opentelemetry-erlang-contrib copied to clipboard

Adding opentelemetry_quantum + opentelemetry_heroku to this project

Open tomtaylor opened this issue 2 years ago • 5 comments
trafficstars

Hello, we've implemented two libraries for OpenTelemetry that we'd like to offer to this project.

Happy to keep maintaining these separately, but I'd love to see them maintained alongside the other libraries if that's useful.

tomtaylor avatar Jun 08 '23 13:06 tomtaylor

Great! Would love to have them in here, and you can remain on as an approver for those particular libs in this repo.

The only issue is the Heroku one should be in Erlang. I think Otel Quantum is fine in Elixir since that is a library for Elixir. Happy to help, if you need it, with the conversion.

tsloughter avatar Jun 08 '23 15:06 tsloughter

Brilliant, thanks. I totally forgot the Heroku one should be in Erlang! My Erlang is a bit rusty, but I can give it a go on a branch and share to check I've got the right approach? It's a very simple library - shouldn't be hard to port over.

tomtaylor avatar Jun 09 '23 08:06 tomtaylor

Sounds good :+1:

tsloughter avatar Jun 09 '23 10:06 tsloughter

Could you give this a look over when you get a moment? I've tried to reimplement it in Erlang, but my Erlang is very rusty!

tomtaylor avatar Jun 12 '23 14:06 tomtaylor

Looks good! But need to update https://github.com/breakroom/opentelemetry_heroku/blob/main/rebar.config#L25

tsloughter avatar Jun 13 '23 11:06 tsloughter