opentelemetry-erlang-contrib icon indicating copy to clipboard operation
opentelemetry-erlang-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

chore: add sc to ecto

Open yordis opened this issue 2 years ago • 4 comments

yordis avatar Dec 18 '22 19:12 yordis

Argh. I seemed to have missed this. It now has conflicts and I think will conflict with https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/65

Trying to get these Ecto PRs all merged but they all have a little bit I'm unsure about.

tsloughter avatar Jul 07 '23 19:07 tsloughter

We should try to convince the adapter authors and Ecto to follow some rules to setup such a key.

Although the alternative PR will work, the direction of dependency where OTEL is aware of ALL things out there is brutal.

Maybe the Ecto team could support it a bit and deprecate that way eventually.

yordis avatar Jul 07 '23 20:07 yordis

@yordis oh and this is still a draft. Is it still not ready?

tsloughter avatar Jul 07 '23 23:07 tsloughter

I mean, kind of yeah. I would probably try to get as many attributes as possible but it seems that #65 has some good stuff there also.

yordis avatar Jul 08 '23 22:07 yordis