opentelemetry-dotnet icon indicating copy to clipboard operation
opentelemetry-dotnet copied to clipboard

Move remaining instrumentation libraries to the opentelemetry-dotnet-contrib repo

Open vishweshbankwar opened this issue 10 months ago • 4 comments

The repo currently maintains the following instrumentation libraries:

  • OpenTelemetry.instrumentation.AspNetCore
  • OpenTelemetry.instrumentation.HttpClient
  • OpenTelemetry.instrumentation.SqlClient
  • OpenTelemetry.instrumentation.GrpcNetClient

We should consider them moving all to the contrib repo and keep this repo focused mainly on core components.

vishweshbankwar avatar Apr 09 '24 23:04 vishweshbankwar

We'll miss some extra test coverage by doing this, but that is okay, since all signals/instrumentations are stable already!

cijothomas avatar Apr 10 '24 16:04 cijothomas

@cijothomas - Thats a good point. I think that can be managed by upgrading the dependencies on instrumentation libraries in timely manner.

vishweshbankwar avatar Apr 10 '24 17:04 vishweshbankwar

Labels on contrib side:

  • https://github.com/open-telemetry/opentelemetry-dotnet-contrib/labels/comp%3Ainstrumentation.grpcnetclient
  • https://github.com/open-telemetry/opentelemetry-dotnet-contrib/labels/comp%3Ainstrumentation.sqlclient
  • https://github.com/open-telemetry/opentelemetry-dotnet-contrib/labels/comp%3Ainstrumentation.httpclient
  • https://github.com/open-telemetry/opentelemetry-dotnet-contrib/labels/comp%3Ainstrumentation.aspnetcore

Kielek avatar Apr 16 '24 10:04 Kielek

Also, migrate the existing GitHub issues that are related to these components.

reyang avatar Apr 24 '24 20:04 reyang

I think this is done.

reyang avatar May 13 '24 21:05 reyang