opentelemetry-dotnet icon indicating copy to clipboard operation
opentelemetry-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

IncludeStateTrace internal ?

Open yassinebennani opened this issue 2 years ago • 3 comments

Question

Use Github Discussions.

Hello Guys,

Can someone please explain to me what is the reason behind defining the property IncludeStateTrace of the class OpenTelemetryLoggerOptions as internal and not public ?

Thank you

yassinebennani avatar Sep 26 '23 12:09 yassinebennani

See PR: #4334

especially https://github.com/open-telemetry/opentelemetry-dotnet/pull/4334#discussion_r1170672257

Nobody make a request/pr for that.

Kielek avatar Sep 26 '23 13:09 Kielek

@yassinebennani We removed it from the public API because we were unsure on the use case and if it was really useful/needed. You want to include trace state on your logs? Can you provide a little detail about the why? I'm interested in how you plan to use that data and why it would be helpful to have.

CodeBlanch avatar Oct 24 '23 22:10 CodeBlanch

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

github-actions[bot] avatar Oct 15 '24 03:10 github-actions[bot]

Closed as inactive. Feel free to reopen if this issue is still a concern.

github-actions[bot] avatar Oct 23 '24 03:10 github-actions[bot]