opentelemetry-dotnet icon indicating copy to clipboard operation
opentelemetry-dotnet copied to clipboard

Make CI checks faster

Open cijothomas opened this issue 2 years ago • 7 comments

image

It looks like a good amount of time is spent on nuget restore. And majority of them from the example projects, which are not required for all the build/test pipelines. We may benefit, if examples are built in a dedicated pipeline, and ignored by other pipelines.

cijothomas avatar Mar 10 '22 18:03 cijothomas

@mic-max will try to check this.

cijothomas avatar Apr 12 '22 20:04 cijothomas

Hi @mic-max and @cijothomas I am wondering if there is still work to be done here? Thanks.

moonbox3 avatar Nov 29 '22 15:11 moonbox3

@mic-max Can you comment if this still has open items?

cijothomas avatar Jan 19 '23 22:01 cijothomas

Ok if I look at this?

ngruson avatar Nov 08 '23 19:11 ngruson

Ok if I look at this?

sure! Thanks for helping.

cijothomas avatar Nov 09 '23 01:11 cijothomas

@cijothomas As is, I don't see NuGet restores taking 5 minutes like in your screenshot. It's more like 2 minutes now on Windows agents.

In my fork, I moved the example projects to a separate solution so that these projects are not built during CI. Another GitHub Actions workflow is building the examples solution separately. But this doesn't make the NuGet restore steps much faster. Probably because there are still web projects in the main solution like TestApp.AspNetCore. OpenTelemetry.Instrumentation.AspNetCore.Tests is depending on TestApp.AspNetCore.

I don't see a need to change the CI workflows imho. If you still think it's beneficial, I can still create a PR.

ngruson avatar Nov 09 '23 20:11 ngruson

Its hard to give a simple answer for this issue as it is a long while since I actively explored this and the other person who continued this is no longer working on this as well..

If the nuget restore's speed is not going to improve significantly by excluding (and building in a separate CI) docs/examples, then this may not be worth exploring.

cijothomas avatar Nov 13 '23 18:11 cijothomas