opentelemetry-dotnet icon indicating copy to clipboard operation
opentelemetry-dotnet copied to clipboard

SpanProcessor.OnStart, Sampler receives parent Context

Open cijothomas opened this issue 4 years ago • 2 comments

Spec requires SpanProcesor.OnStart to receive the span and parentcontext (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#onstart). The .NET Implementation only provides Activity to OnStart on ActivityProcessor, and does not explicitly provide a parent Context. However, it is possible to use Activity.Current.Parent.ActivityContext, and Baggage.Current to access parent ActivityContext, and Baggage. Due to the difference in Activity semantics, and the way context is handled, it is not clear if we should mark "+" or "-" for the spec-compliance-matrix "SpanProcessor.OnStart receives parent Context".

Same issue for Sampler as well.

Marking "-" for these entries now.

cijothomas avatar Feb 03 '21 18:02 cijothomas

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

github-actions[bot] avatar Aug 16 '24 03:08 github-actions[bot]

Closed as inactive. Feel free to reopen if this issue is still a concern.

github-actions[bot] avatar Aug 24 '24 03:08 github-actions[bot]

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

github-actions[bot] avatar Jun 21 '25 03:06 github-actions[bot]