opentelemetry-dotnet icon indicating copy to clipboard operation
opentelemetry-dotnet copied to clipboard

Decide on a clear exception handling strategy for extensibility components in SDK

Open utpilla opened this issue 4 years ago • 3 comments

We need to decide on whether we should let faulty third party extensibility components crash the SDK.

There are several extensibility components which can throw an exception anytime after initialization, and can cause app to fail in the middle of execution.

  • Sampler
  • Processor
  • Exporter (SimpleExportProcessor catches exceptions thrown by an exporter)
  • Instrumentation's Enrich
  • Instrumentations's Filter - (We do catch user exception here)
  • ExemplarFilter
  • ExemplarReservoir

utpilla avatar Dec 02 '20 02:12 utpilla

I believe that we're solved this in that all those examples won't cause a failure.

I'd suggest, if there is more to this, that a ticket as a bug is created and if there is discussion to be had, we reopen this and discuss at the next SIG so we can get concrete actions.

martinjt avatar Dec 12 '23 21:12 martinjt

I believe that we're solved this in that all those examples won't cause a failure.

A custom extension component can throw an exception. We need to formulate our stance on how we want to treat them. It would be good to discuss this in the SIG meeting.

utpilla avatar Dec 12 '23 21:12 utpilla