opentelemetry-dotnet-instrumentation icon indicating copy to clipboard operation
opentelemetry-dotnet-instrumentation copied to clipboard

IntegrationTests.SqlClientTests.SubmitTraces [FAIL] Microsoft.Data.SqlClient.SqlException (0x80131904): Login failed for user 'sa'.

Open pellared opened this issue 2 years ago • 2 comments

https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/runs/7444225072?check_suite_focus=true

Flaky? Is it a problem with the generated password?

pellared avatar Jul 21 '22 07:07 pellared

Any other reports of this one?

pjanotti avatar Jul 28 '22 18:07 pjanotti

Any other reports of this one?

I've only seen it once. During the SIG meeting we decided to keep this issue around and tentatively scheduling looking into it after we wrap up our 0.3.0-beta milestone.

nrcventura avatar Jul 28 '22 19:07 nrcventura

Same failure at https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/runs/7924735948?check_suite_focus=true#step:5:2188

pjanotti avatar Aug 19 '22 19:08 pjanotti

Another one https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/runs/7924836032?check_suite_focus=true#step:5:2193

Now it looks more than just flakiness. Bumping this to 0.3.0 until we are sure.

cc @open-telemetry/dotnet-instrumentation-approvers

pjanotti avatar Aug 19 '22 19:08 pjanotti

It passed on retries, but, there were a relatively high number of failures. Likely this is a test issue but we should investigate and fix it if appropriate before 0.3.0.

pjanotti avatar Aug 19 '22 23:08 pjanotti

I couldn't repro the exact same error (tried multiple runs delaying start of the docker, incorrect password, invalid sa password, etc). I will move this back to 0.4.0 since it really seems something related to the CI environment.

pjanotti avatar Aug 22 '22 19:08 pjanotti

Flaky? Is it a problem with the generated password?

In my opinion it is not related to generated password. I was able to take generated password from failing execution and execute test on my env. It passed.

Kielek avatar Aug 23 '22 05:08 Kielek

All failures are related to exit code 134.

Is it SIGABORT?

Kielek avatar Aug 23 '22 10:08 Kielek

Still occurring after #1122 merge https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/runs/7988227878?check_suite_focus=true

Kielek avatar Aug 24 '22 06:08 Kielek