opentelemetry-dotnet-instrumentation icon indicating copy to clipboard operation
opentelemetry-dotnet-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

[kafka] update messaging operation attribute name

Open lachmatt opened this issue 10 months ago • 1 comments

Why

Update attribute name to match current semantic conventions.

Fixes #

What

Attribute rename.

Tests

Existing tests.

Checklist

  • [ ] CHANGELOG.md is updated.
  • [ ] Documentation is updated.
  • [ ] New features are covered by tests.

lachmatt avatar Apr 17 '24 13:04 lachmatt

The change itself looks good, however, we're currently actively working on stabilizing semantic conventions for messaging, and other breaking changes might come up. That's why we have this disclaimer on the messaging semantic convention document:

Warning Existing messaging instrumentations that are using v1.24.0 of this document (or prior) SHOULD NOT change the version of the messaging conventions that they emit until a transition plan to the (future) stable semantic conventions has been published. Conventions include, but are not limited to, attributes, metric and span names, and unit of measure.

So to avoid churn, we recommend to avoid releasing any changes to users until semantic conventions for messaging are stable. The result would be just one (bigger) breaking change instead of multiple (smaller) ones.

pyohannes avatar Apr 17 '24 14:04 pyohannes