opentelemetry-dotnet-instrumentation icon indicating copy to clipboard operation
opentelemetry-dotnet-instrumentation copied to clipboard

Proposal: Support well known resource detectors

Open RassK opened this issue 2 years ago • 3 comments

What

Support well known resource detectors automatically.

List:

  • [x] Docker
  • [x] Azure
  • [ ] AWS[^1]
  • [ ] Kubernetes
  • (Add your thought here...)

[^1]: Seems this package has mixed up instrumentations and resources? Could be worth checking before implementing.

RassK avatar Mar 30 '23 14:03 RassK

I think that the user can get these resources using the OTel Collector. I am not sure if we need to have it in auto-instrumentation (more dependencies, bigger package, more maintenance).

pellared avatar Apr 03 '23 09:04 pellared

AWS packages are subject to change under contrib repository (including renaming). If we need only part of this, we could probably extract resource package.

Kielek avatar Apr 03 '23 09:04 Kielek

SIG meeting:

  • Needs to be configurable similar to what is done for instrumentations (fine and coarse level control)
  • Short run: add "low dependencies" detector: docker first and AZ when package is ready
  • Medium term: decide about how to support more complex packages (e.g.: AWS)

pjanotti avatar Apr 05 '23 16:04 pjanotti

For now, we supporting following resource detectors:

  • AZUREAPPSERVICE
  • CONTAINER
  • HOST
  • PROCESS
  • PROCESSRUNTIME.

If there is a needs for others, please create separate issue/PR. Closing.

Kielek avatar Feb 16 '24 08:02 Kielek