opentelemetry-dotnet-instrumentation icon indicating copy to clipboard operation
opentelemetry-dotnet-instrumentation copied to clipboard

Bump Microsoft.Extensions.Logging.Abstractions from 6.0.0 to 6.0.2 in /src/OpenTelemetry.AutoInstrumentation.AdditionalDeps

Open dependabot[bot] opened this issue 1 year ago • 1 comments

Bumps Microsoft.Extensions.Logging.Abstractions from 6.0.0 to 6.0.2.

Release notes

Sourced from Microsoft.Extensions.Logging.Abstractions's releases.

.NET 6.0.2

Release

.NET 6.0.1

Release

Commits
  • 839cdfb Merge in 'release/6.0' changes
  • 6de5c5b [wasm][debugger] Missing test files (#63148)
  • 71075a0 Merge in 'release/6.0' changes
  • 3c2d2a1 Fix the MacOS remote unwinder for VS4Mac (#63405)
  • d8f7045 Merge in 'release/6.0' changes
  • fe7335c [release/6.0] Use "read" to fetch misaligned 64bit values from bundle header ...
  • 5e9fd16 Merge in 'release/6.0' changes
  • beedfae [release/6.0] Build all packages when in source-build (#63653)
  • 56c11f2 Merge in 'release/6.0' changes
  • 27eb94b Merge in 'release/6.0' changes
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Sep 14 '22 12:09 dependabot[bot]

@dependabot rebase

Kielek avatar Sep 15 '22 12:09 Kielek

@dependabot rebase

rajkumar-rangaraj avatar Sep 26 '22 23:09 rajkumar-rangaraj

@rajkumar-rangaraj I'm leaning towards closing this PR and perhaps marking it as ignored in the dependabot config. However, since we package this dependency as a fallback, should we ensure that we use the latest patch release? I'm not sure if doing that will lead to other dependency resolution issues.

nrcventura avatar Sep 29 '22 19:09 nrcventura

@nrcventura Yes, we could close this PR.

It's recommended to maintain the latest version of the packages in OpenTelemetry.AutoInstrumentation.AdditionalDeps to avoid dependency resolution issues.

rajkumar-rangaraj avatar Sep 29 '22 20:09 rajkumar-rangaraj

It's recommended to maintain the latest version of the packages in OpenTelemetry.AutoInstrumentation.AdditionalDeps to avoid dependency resolution issues.

If that's the case, and it won't cause dependency resolution problems, perhaps we need to update the *.verified files and merge this PR?

nrcventura avatar Sep 29 '22 20:09 nrcventura

To keep it clean, we could close this dependabot PR and create a new PR with all changes.

rajkumar-rangaraj avatar Sep 29 '22 20:09 rajkumar-rangaraj

After this bump we get two (sic!) versions of Microsoft.Extensions.Logging.Abstractions: 6.0.0 and 6.0.2 under \store. Does anyone have an idea why (I have not made any deep analysis)?

pellared avatar Sep 30 '22 15:09 pellared

Transitive dependency by Microsoft.Extensions.Logging.Configuration?

Kielek avatar Sep 30 '22 18:09 Kielek

@dependabot rebase

Kielek avatar Oct 25 '22 05:10 Kielek

Duplicated libraries are removed based on list. Build should fail if the dependency will be no available or it will be referenced from json file. Output structure tests should cover verification phase for manual modifications.

It is ugly, but in my opinion it is better than overriding msbuild steps.

Kielek avatar Oct 25 '22 06:10 Kielek