opentelemetry-dotnet-contrib icon indicating copy to clipboard operation
opentelemetry-dotnet-contrib copied to clipboard

AWS Lambda support for extraction of W3C trace headers sent over http

Open khpeet opened this issue 3 years ago • 4 comments
trafficstars

Issue with OpenTelemetry.Contrib.Instrumentation.AWSLambda

List of all OpenTelemetry NuGet packages and version that you are using (e.g. OpenTelemetry 1.0.2):

    <PackageReference Include="OpenTelemetry.Contrib.Instrumentation.AWS" Version="1.0.1" />
    <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.1.0-beta1" />
    <PackageReference Include="OpenTelemetry.Contrib.Instrumentation.AWSLambda" Version="1.1.0-beta1" />
    <PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc8" />

Runtime version (e.g. net462, net48, netcoreapp3.1, net6.0 etc. You can find this information from the *.csproj file):

netcoreapp3.1

Is this a feature request or a bug?

  • [x] Feature Request
  • [ ] Bug

What is the expected behavior?

Incoming http W3C trace headers are extracted and added to the active span created. Currently only headers from X-Ray are extracted according to the comments in this method.

What is the actual behavior? I am sending traceparent and tracestate headers from a client SPA to an AWS dotnetcore3.1 Lambda using this wrapper. Currently the trace context sent via HTTP headers are not automatically extracted via this wrapper, thus I have reverted to not use this wrapper and am manually creating my own Spans/extraction of context.

khpeet avatar May 04 '22 19:05 khpeet

@srprash -- @alanwest recommended to tag you

khpeet avatar May 05 '22 11:05 khpeet

I'm also experiencing the same issue with a project I'm working with. Hope this can be solved soon.

jmpf2019 avatar May 12 '22 16:05 jmpf2019

Hi @khpeet and @jmpf2019 Thanks for opening this feature request. Adding support for W3C in the AWS Lambda instrumentation is on our backlog, however I cannot provide and ETA for it at the moment. I will provide an update as soon as possible.

srprash avatar May 12 '22 16:05 srprash

hey @srprash - is there any progress on this? Thanks!

khpeet avatar Jun 28 '22 20:06 khpeet

Hi @srprash, same as previous comment ^, checking if there's any progress on this.

jmpf2019 avatar Sep 28 '22 21:09 jmpf2019

This should now be implemented by #408, check the release notes of 1.1.0-beta.2 here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md

Oberon00 avatar Nov 09 '22 08:11 Oberon00

Can someone with permissions please close this issue? See my previous comment.

Oberon00 avatar Jul 17 '23 14:07 Oberon00

Closing per @Oberon00 comment.

Kielek avatar Jul 19 '23 08:07 Kielek