opentelemetry-dotnet-contrib icon indicating copy to clipboard operation
opentelemetry-dotnet-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add unit tests to ConfluentKafka instrumentration

Open g7ed6e opened this issue 7 months ago • 0 comments 

          Looks good to me overall. Left couple minor comments that can be addressed in the follow up.

I do have the same concern as @CodeBlanch noted in https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1493#issuecomment-2189854737 about the lack of unit tests. Given this PR is already big, it can be addressed in a follow up.

Originally posted by @vishweshbankwar in https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1493#pullrequestreview-2148696565

g7ed6e avatar Jul 01 '24 07:07 g7ed6e