opentelemetry-dotnet-contrib icon indicating copy to clipboard operation
opentelemetry-dotnet-contrib copied to clipboard

Semantic convention package should be used by libraries

Open thompson-tomo opened this issue 1 year ago • 4 comments

Component

None

Is your feature request related to a problem?

Duplicated code

What is the expected behavior?

That no projects redefine semantic convention strings & instead they leverage the appropriate package.

Note it needs to be determined how deprecation are handled as otherwise we could end up with breaking changes

Which alternative solutions or features have you considered?

Allow the duplication and effectively have very little use for the conventions package

Additional context

No response

thompson-tomo avatar May 28 '24 18:05 thompson-tomo

My proposal for discontinuation would be to use the obselete attribute & potentially make our our own attributes for experimental/opt-in which generate build info/warnings etc

thompson-tomo avatar May 29 '24 01:05 thompson-tomo

There's an ongoing project for generating the Semantic convention packages. There's lots of implications of Obsolete, duplicates, and how package versions works across multiple languages, which is why it's taking a while.

When we have moved to that, we'll be looking at whether we should use the package in our instrumentations.

martinjt avatar Jun 01 '24 18:06 martinjt

potentially make our our own attributes for experimental/opt-in which generate build info/warnings

Just FYI .NET 8 added ExperimentalAttribute.

CodeBlanch avatar Jun 12 '24 19:06 CodeBlanch

yeap i noticed in one of my recent projects, so that would certainly be useful we just need to establish a way for the class generator to populate the correct attributes on the properties to ensure it is a maintainable process.

thompson-tomo avatar Jun 12 '24 23:06 thompson-tomo