opentelemetry-dotnet-contrib
opentelemetry-dotnet-contrib copied to clipboard
open-telemetry
Move Existing ServerCertificateValidation Classes to Shared
Attempt to move the ServerCertificateValidtion Classes to the Shared folder. This use case is very generic and has potential to be used for multiple ResourceDetector Projects. It was also intended to be used in the ResourceDetectors.Container Project in https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1529.
One reservation I have for this is the ideal location for the test cases, as they currently just exist in the ResourceDetectors.AWS.Tests Test project.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.77%. Comparing base (
71655ce) to head (fa08aa6). Report is 178 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
- Coverage 73.91% 73.77% -0.14%
==========================================
Files 267 256 -11
Lines 9615 9415 -200
==========================================
- Hits 7107 6946 -161
+ Misses 2508 2469 -39
| Flag | Coverage Δ | |
|---|---|---|
| unittests-Exporter.Geneva | 58.21% <ø> (?) |
|
| unittests-Exporter.OneCollector | 89.72% <ø> (?) |
|
| unittests-Extensions | 82.75% <ø> (?) |
|
| unittests-Instrumentation.AspNet | 75.82% <ø> (?) |
|
| unittests-Instrumentation.EventCounters | 75.92% <ø> (?) |
|
| unittests-Instrumentation.Owin | 85.71% <ø> (?) |
|
| unittests-Instrumentation.Process | 100.00% <ø> (?) |
|
| unittests-Instrumentation.Runtime | 100.00% <ø> (?) |
|
| unittests-Instrumentation.StackExchangeRedis | 71.00% <ø> (?) |
|
| unittests-Instrumentation.Wcf | 78.47% <ø> (?) |
|
| unittests-PersistentStorage | 65.78% <ø> (?) |
|
| unittests-ResourceDetectors.Azure | 81.53% <ø> (?) |
|
| unittests-ResourceDetectors.Host | 40.00% <ø> (?) |
|
| unittests-ResourceDetectors.Process | 100.00% <ø> (?) |
|
| unittests-ResourceDetectors.ProcessRuntime | 76.08% <ø> (?) |
|
| unittests-Solution | 79.92% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| ...ry.ResourceDetectors.AWS/AWSEKSResourceDetector.cs | 58.62% <100.00%> (ø) |
|
| ...y.ResourceDetectors.AWS/AWSResourcesEventSource.cs | 62.50% <ø> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR was marked stale due to lack of activity. It will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR was marked stale due to lack of activity. It will be closed in 7 days.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Attempt to move the ServerCertificateValidtion Classes to the Shared folder. This use case is very generic and has potential to be used for multiple ResourceDetector Projects. It was also intended to be used in the ResourceDetectors.Container Project in #1529.
@srprash @atshaw43 @ppittle This PR intends to move ServerCertificateValidation related code from OpenTelemetry.ResourceDetectors.AWS to src/Shared as that code is a good candidate to be shared by other components as well. If moved to the shared folder, OpenTelemetry.ResourceDetectors.Container would like to use them for #1529. Could you please review this change?
One reservation I have for this is the ideal location for the test cases, as they currently just exist in the ResourceDetectors.AWS.Tests Test project.
I think individual components that end up using the ServerCertificateValidation code can test the functionality in their own test projects.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
As @anoopbabu29 is not really active, I'm ready to help on this PR (especially to unblock #1562/#1529). If it's ok for you, you can close this PR and I'll open a new one then.
Closing, per https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1550#issuecomment-2041144409
