opentelemetry-demo
opentelemetry-demo copied to clipboard
39 Moving the Front end application from Go to Next.js
Fixes https://github.com/open-telemetry/opentelemetry-demo/issues/39.
Changes
In this PR we are introducing the new front-end version. In this version, we are focusing on having a browser-side client written in Typescript.
The frontend was built based on the proposal presented during the last SIG call (July 25th 2022) and can be found here: https://docs.google.com/presentation/d/1klWGRAcFYJLBrXtMMRGHJvwQaMt1JPWnO7qQzFdJti4/edit?usp=sharing
Next Steps:
- Add instrumentation.
- Add unit tests and integration tests.
For significant contributions please make sure you have completed the following items:
- [ ] Appropriate
CHANGELOG.md
updated for non-trivial changes - [x] Design discussion issue https://github.com/open-telemetry/opentelemetry-demo/issues/39
Video demo
https://www.loom.com/share/c7b1c559346e4a4c8df4e670ef14b558
Screenshots
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: xoscar / name: Oscar Reyes (3e873e2683cb0e08ffb96d8718866f8075c8cfa0, 290c7b8bc956cf5cd42452b4ef7f9b0ffab95218, 7213709c62f47331746dca17c7365975f66d1c37, e71da1a768baa07a5611d14ea46dee251c8e7a51, 439f7951f5e50f27ad0aaca905a81071cf08940d, e63d9fb321a0adcd9a402938f93b20d73790f631, 96bbd2cf03e03436b765c2a9c3e838dd6eda7e73, 3a7b71f6b5bc3b89cabdf37d4c0dbd5c792bd388)
Make sure to go ahead & sign the cla @xoscar
Thanks for your contribution, @xoscar! Would you update the PR title to capture the intention? It's hard to understand what "39 web application" is unless someone reads through the details (and later it will cause pain if someone want to search old PRs).
Could we get the checks passing on this to move it forward?
I believe that we can also get rid of the social network icons, we are not using them within the FE.
I didn't mark the PR as need work because I'm will be OoO for some time, but went through all files and added my review!
This was a really massive one 😅
Ah, btw...
The loadgen is failing because the FE url is different now.
Maybe we could consider either moving from 8081
to 8080
or updating the loadgen endpoint as well.
Ah, btw... The loadgen is failing because the FE url is different now. Maybe we could consider either moving from
8081
to8080
or updating the loadgen endpoint as well.
I fixed the endpoint for the loadgen but the scenarios are no longer "valid" as the app does not support the same POST/GET endpoints. I'll update it with better next as part of a follow up PR
@wph95 , @cedricziel , @mic-max , @open-telemetry/demo-approvers - ready for final reviews
Hey @mic-max thanks for reviewing the PR 😁 I just updated it based on your changes, let me know if that's good enough to merge the changes. @cartersocha I think we need to press the button one last time 😄
@wph95 , @cedricziel , @mic-max , @open-telemetry/demo-approvers - ready for final reviews
I don't know how to effectively review any PR that has more than a hundred files. Maybe it should be changed to a series of smaller PRs?
@wph95 , @cedricziel , @mic-max , @open-telemetry/demo-approvers - ready for final reviews
I don't know how to effectively review any PR that has more than a hundred files. Maybe it should be changed to a series of smaller PRs?
The idea of one big PR was to not have intermediate commits where the frontend might be broken, this PR adds all of the features the GO version used to have plus the new redesigns.
The next ones should be fairly small as we will only focus on one section like:
- Instrumentation.
- E2E tests.
Thanks @xoscar! Huge contribution 🌟
Thank you @xoscar for this!!! 💯