opentelemetry-demo icon indicating copy to clipboard operation
opentelemetry-demo copied to clipboard

enhance metric support for product catalog service

Open Frapschen opened this issue 2 years ago • 3 comments

Fixes #66

Changes

supprot runtime metrics for productcatalogservice.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #66

Frapschen avatar Jul 26 '22 03:07 Frapschen

@cartersocha, please review. current implementation is not a push style, we really need it? it will add a new component,a Prometheus Pushgateway, I think it more costly, a static config for promethues is ok for me.

Frapschen avatar Jul 26 '22 03:07 Frapschen

@cartersocha, please review. current implementation is not a push style, we really need it? it will add a new component,a Prometheus Pushgateway, I think it more costly, a static config for promethues is ok for me.

I think push gateway is not needed, we should use otel library to export metrics to otel-collector, the prometheus already scraped metrics from collector.

fatsheep9146 avatar Jul 26 '22 04:07 fatsheep9146

ok, I will use the OTel library to do it

Frapschen avatar Aug 01 '22 08:08 Frapschen

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Aug 09 '22 03:08 github-actions[bot]

Any updates on this?

austinlparker avatar Aug 15 '22 15:08 austinlparker

I want wait this issue finish https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2624, its a new version of instrumentation

Frapschen avatar Aug 16 '22 02:08 Frapschen

I want wait this issue finish open-telemetry/opentelemetry-go-contrib#2624, its a new version of instrumentation

Does that issue have anyone actively working on it? It doesn't seem like it does... could we just use whatever the current version of go otel metrics instrumentation is, then when the new version comes out, update to that?

austinlparker avatar Aug 19 '22 15:08 austinlparker

Closing as the product catalog service was overhauled and will need to be updated.

cartersocha avatar Aug 29 '22 15:08 cartersocha