opentelemetry-demo
opentelemetry-demo copied to clipboard
enhance metric support for product catalog service
Fixes #66
Changes
supprot runtime metrics for productcatalogservice.
For significant contributions please make sure you have completed the following items:
- [ ] Appropriate
CHANGELOG.md
updated for non-trivial changes - [ ] Design discussion issue #66
@cartersocha, please review. current implementation is not a push style, we really need it? it will add a new component,a Prometheus Pushgateway, I think it more costly, a static config for promethues is ok for me.
@cartersocha, please review. current implementation is not a push style, we really need it? it will add a new component,a Prometheus Pushgateway, I think it more costly, a static config for promethues is ok for me.
I think push gateway is not needed, we should use otel library to export metrics to otel-collector, the prometheus already scraped metrics from collector.
ok, I will use the OTel library to do it
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Any updates on this?
I want wait this issue finish https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2624, its a new version of instrumentation
I want wait this issue finish open-telemetry/opentelemetry-go-contrib#2624, its a new version of instrumentation
Does that issue have anyone actively working on it? It doesn't seem like it does... could we just use whatever the current version of go otel metrics instrumentation is, then when the new version comes out, update to that?
Closing as the product catalog service was overhauled and will need to be updated.