opentelemetry-demo icon indicating copy to clipboard operation
opentelemetry-demo copied to clipboard

change docker-compse image pull way

Open Frapschen opened this issue 1 year ago • 3 comments

Feature Request

the docker-compse current use build command to create the image, it often occur unexpected problem when someone want to take a look the demo, like #178 #170 #126, and I notice #184 had merged, can we use the prebuild image instead of build localy? by the way, there is also don't have a clearly way to kown how to find the demo image in docker hub.

Frapschen avatar Jul 08 '22 03:07 Frapschen

Hi sorry to reply later

the docker-compse current use build command to create the image, it often occur unexpected problem when someone want to take a look the demo

As I understand it, there is no contradiction between having image and build at the same time. https://docs.docker.com/compose/compose-file/#image If the corresponding image is not available locally, it will try to pull it, and if that fails, it will build it locally.

The problem we're currently having, I think, is that the python image we're using has some issues running on ARM. I don't think this is a problem caused by our build.

wph95 avatar Jul 20 '22 19:07 wph95

by the way, there is also don't have a clearly way to kown how to find the demo image in docker hub.

I'm very sorry about this. We are not ready to document about this thing yet. This thing is still a work in progress. The plan is to have detailed documentation explaining the corresponding issues when the helm chart is released. If you are interested in this matter, you can see the context in this issue.

wph95 avatar Jul 20 '22 19:07 wph95

yes, there is no contradiction, the image command have added, I don't notice it. the README.md need a little imporve, only run docker compose up the pull stage will fail, if there is a note 'if you want to test the pre-build image, you need export the IMAGE_NAME and IMAGE_VERSION enviroment' the guidance will be better.

Frapschen avatar Jul 22 '22 04:07 Frapschen

Hey we've implemented this now. Check our most recent docs

cartersocha avatar Oct 06 '22 20:10 cartersocha