opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Add bundle version of utf8_range to validate attributes

Open owent opened this issue 6 months ago • 3 comments

Fixes #3491

Changes

  • Add bundle version of utf8_range to validate attribute values

For significant contributions please make sure you have completed the following items:

  • [x] CHANGELOG.md updated for non-trivial changes
  • [x] Unit tests have been added
  • [x] Changes in public API reviewed

owent avatar Jul 01 '25 12:07 owent

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
Latest commit 2ab31e85f5fddf56be2d25c23cb685cba22a1915
Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68a8d5196a46540008c6326f

netlify[bot] avatar Jul 01 '25 12:07 netlify[bot]

Codecov Report

:x: Patch coverage is 58.62069% with 96 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 88.97%. Comparing base (9de3493) to head (893fc56).

Files with missing lines Patch % Lines
sdk/src/common/attribute_validity.cc 56.10% 36 Missing :warning:
sdk/src/common/internal/utf8_range/uft8_range.cc 50.00% 33 Missing :warning:
...lude/opentelemetry/sdk/common/attribute_validity.h 63.64% 12 Missing :warning:
...y/sdk/instrumentationscope/instrumentation_scope.h 61.12% 7 Missing :warning:
sdk/src/trace/span.cc 64.71% 6 Missing :warning:
...ntelemetry/sdk/metrics/view/attributes_processor.h 66.67% 1 Missing :warning:
sdk/src/resource/resource.cc 92.31% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3512      +/-   ##
==========================================
- Coverage   89.93%   88.97%   -0.96%     
==========================================
  Files         225      228       +3     
  Lines        7158     7376     +218     
==========================================
+ Hits         6437     6562     +125     
- Misses        721      814      +93     
Files with missing lines Coverage Δ
...ntelemetry/sdk/metrics/view/attributes_processor.h 84.62% <66.67%> (ø)
sdk/src/resource/resource.cc 95.13% <92.31%> (-1.65%) :arrow_down:
sdk/src/trace/span.cc 85.72% <64.71%> (-4.05%) :arrow_down:
...y/sdk/instrumentationscope/instrumentation_scope.h 87.28% <61.12%> (-12.72%) :arrow_down:
...lude/opentelemetry/sdk/common/attribute_validity.h 63.64% <63.64%> (ø)
sdk/src/common/internal/utf8_range/uft8_range.cc 50.00% <50.00%> (ø)
sdk/src/common/attribute_validity.cc 56.10% <56.10%> (ø)

... and 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 01 '25 12:07 codecov[bot]

The clang-tidy check failure does not appear to be caused by this PR.

owent avatar Nov 29 '25 05:11 owent