opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

[REMOVAL] Removed deprecated semantic convention header files.

Open marcalff opened this issue 6 months ago • 2 comments

Fixes #3169

Removed deprecated code, as announced earlier on Nov 9, 2024:

Deprecation is announced as part of the migration to weaver:

* `Version:` release following opentelemetry-cpp 1.17.0
* `Date:` Nov 9, 2024
* `PR:` [PR 3105](https://github.com/open-telemetry/opentelemetry-cpp/pull/3105)

Changes

Please provide a brief description of the changes here.

  • Removed deprecated semantic convention headers.
  • Updated maintainers documentation to reflect the new process with weaver.

For significant contributions please make sure you have completed the following items:

  • [ ] CHANGELOG.md updated for non-trivial changes
  • [ ] Unit tests have been added
  • [ ] Changes in public API reviewed

marcalff avatar Jun 12 '25 19:06 marcalff

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
Latest commit d569ad4c00552146f9f78c1016732ce4fac5d13a
Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6850869d3493d600081a6a38

netlify[bot] avatar Jun 12 '25 20:06 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.92%. Comparing base (3d901a8) to head (d569ad4). Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3475      +/-   ##
==========================================
+ Coverage   89.91%   89.92%   +0.02%     
==========================================
  Files         219      219              
  Lines        7042     7042              
==========================================
+ Hits         6331     6332       +1     
+ Misses        711      710       -1     

see 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 12 '25 20:06 codecov[bot]

LGTM. Although it was deprecated, it's still worth including a changelog entry with migration steps for those who haven't removed it yet.

Good idea, thanks. Implemented, waiting for CI to complete.

marcalff avatar Jun 16 '25 21:06 marcalff