opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

[BUILD] Read default proto version from `third_party_release`

Open owent opened this issue 1 year ago • 1 comments

Fixes #2676

Changes

  • Read default proto version from third_party_release
  • Format cmake/opentelemetry-proto.cmake

For significant contributions please make sure you have completed the following items:

  • [ ] CHANGELOG.md updated for non-trivial changes
  • [ ] Unit tests have been added
  • [ ] Changes in public API reviewed

owent avatar May 23 '24 03:05 owent

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.70%. Comparing base (497eaf4) to head (4d6b314). Report is 67 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2677      +/-   ##
==========================================
+ Coverage   87.12%   87.70%   +0.58%     
==========================================
  Files         200      190      -10     
  Lines        6109     5852     -257     
==========================================
- Hits         5322     5132     -190     
+ Misses        787      720      -67     

see 57 files with indirect coverage changes

codecov[bot] avatar May 23 '24 03:05 codecov[bot]

Thanks for the fix.

See suggested change.

Not sure why opentelemetry-proto.cmake was not formatted in my previous change, as CI was ok on format.

Maybe we should use cmake-format -i $($FIND -name 'CMakeLists.txt' -print -o -name '*.cmake' -print -o -name '*.cmake.in' -print) in tools/format.sh. (Add -o between rules.)

owent avatar May 28 '24 04:05 owent