opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Add support for bzlmod

Open keith opened this issue 1 year ago • 5 comments

This adds support for bzlmod, which is bazel's new dependency resolution system.

Theoretically we could now remove the previous dependency management configuration which required flattening all the dependencies, but I left it here for now for users using old versions of bazel.

Fixes: https://github.com/open-telemetry/opentelemetry-cpp/issues/2334

keith avatar Mar 25 '24 17:03 keith

this will probably fail CI with the same issue as https://github.com/open-telemetry/opentelemetry-cpp/pull/2599

keith avatar Mar 25 '24 17:03 keith

ok I pushed an update here that seems to fix it at least with c++17, it depends on https://github.com/bazelbuild/bazel-central-registry/pull/1810

keith avatar Apr 12 '24 19:04 keith

Hi @keith

Could you merge with a recent main to resolve conflicts, and investigate the remaining CI failures for bazel if any ?

Thanks, -- Marc

marcalff avatar May 06 '24 16:05 marcalff

The windows and asan failures here are real.

keith avatar May 06 '24 22:05 keith

hopefully will be unblocked by https://github.com/open-telemetry/opentelemetry-cpp/pull/2679

keith avatar May 23 '24 23:05 keith

@keith

Now that #2679 is merged, could you update this PR and resolve conflicts ?

Looking to include this in the upcoming release.

Thanks.

marcalff avatar Jun 12 '24 05:06 marcalff

I think there might still be a grpc ODR issue I have to fix, but we'll see if CI fails

keith avatar Jun 12 '24 16:06 keith

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.67%. Comparing base (497eaf4) to head (44f193b). Report is 79 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2608      +/-   ##
==========================================
+ Coverage   87.12%   87.67%   +0.55%     
==========================================
  Files         200      190      -10     
  Lines        6109     5851     -258     
==========================================
- Hits         5322     5129     -193     
+ Misses        787      722      -65     

see 79 files with indirect coverage changes

codecov[bot] avatar Jun 12 '24 16:06 codecov[bot]

thanks!

keith avatar Jun 13 '24 16:06 keith