opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

[EXPORTER] Error when grpc endpoint is empty

Open HennerM opened this issue 1 year ago • 6 comments

Changes

It seems like there is nothing checking whether the grpc exporter is actually empty, in which case it doesn't make sense to create a gRPC channel. This causes a problem in my application where we accidentally create a GrpcExporter with empty endpoint, which we never use because of a NOOP sampler.

I believe it could be useful to log an error here, similar to when the endpoint is no valid URI.

HennerM avatar Jan 23 '24 20:01 HennerM

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: HennerM / name: Markus Hennerbichler (d1cec0b8cf4845e20588314f60d4baf5ca1646fe)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.09%. Comparing base (497eaf4) to head (de2f639). Report is 10 commits behind head on main.

:exclamation: Current head de2f639 differs from pull request most recent head d1cec0b. Consider uploading reports for the commit d1cec0b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   87.12%   87.09%   -0.02%     
==========================================
  Files         200      200              
  Lines        6109     6103       -6     
==========================================
- Hits         5322     5315       -7     
- Misses        787      788       +1     

see 3 files with indirect coverage changes

codecov[bot] avatar Jan 23 '24 20:01 codecov[bot]

@HennerM

Thanks for the PR. Please sign the CLA so it can be merged.

After signing, if the CI does not detect the change, please add a comment with a single line "/easycla" command, to poke github to reevaluate.

marcalff avatar Jan 24 '24 13:01 marcalff

Thanks @marcalff , I am just getting the CLA for my organisation through, could take a day or so

HennerM avatar Jan 24 '24 15:01 HennerM

/easycla

marcalff avatar Feb 06 '24 15:02 marcalff

Hi @HennerM .

Any update on the CLA ?

marcalff avatar Feb 06 '24 16:02 marcalff

Hi @HennerM .

Any update on the CLA ?

yes unfortunately the EasyCLA landed in the spam folder of the responsible person in my organisation, but it should get through soon now

HennerM avatar Feb 13 '24 19:02 HennerM

/easycla

HennerM avatar Feb 23 '24 15:02 HennerM