opentelemetry-cpp
opentelemetry-cpp copied to clipboard
[WIP] Synchronous Gauge
Fixes #2279 , #2155
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
- [ ]
CHANGELOG.mdupdated for non-trivial changes - [ ] Unit tests have been added
- [ ] Changes in public API reviewed
Codecov Report
Merging #2341 (1248928) into main (cb603ad) will decrease coverage by
0.39%. The diff coverage is55.69%.
:exclamation: Current head 1248928 differs from pull request most recent head 272f30f. Consider uploading reports for the commit 272f30f to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #2341 +/- ##
==========================================
- Coverage 87.41% 87.02% -0.39%
==========================================
Files 199 199
Lines 6028 6036 +8
==========================================
- Hits 5269 5252 -17
- Misses 759 784 +25
| Files | Coverage Δ | |
|---|---|---|
| api/include/opentelemetry/metrics/meter.h | 100.00% <ø> (ø) |
|
| api/include/opentelemetry/metrics/noop.h | 41.18% <ø> (+3.93%) |
:arrow_up: |
| ...i/include/opentelemetry/metrics/sync_instruments.h | 100.00% <100.00%> (ø) |
|
| sdk/include/opentelemetry/sdk/metrics/meter.h | 57.15% <ø> (ø) |
|
| ...clude/opentelemetry/sdk/metrics/sync_instruments.h | 100.00% <ø> (+19.52%) |
:arrow_up: |
| sdk/src/metrics/meter.cc | 61.45% <100.00%> (ø) |
|
| ...etry/sdk/metrics/aggregation/default_aggregation.h | 70.13% <0.00%> (ø) |
|
| sdk/src/metrics/sync_instruments.cc | 65.84% <53.09%> (-13.05%) |
:arrow_down: |
Thanks for taking on the implementation for Gauge.
A few early comments.
Thanks for the comments. Need to add unit-tests before making it ready now.
closing as there needs a design change. Will raise a new PR.
closing as there needs a design change. Will raise a new PR.
Hello @lalitb, Do you have any plan or timeline to add synchronous gauge support for OpenTelemetry SDK C++?
Hello @lalitb, Do you have any plan or timeline to add synchronous gauge support for OpenTelemetry SDK C++?
Sorry, no timeline yet. It may take a couple of months for me to get back to it. If someone picks it up meanwhile, it would be great.
Sorry, no timeline yet. It may take a couple of months for me to get back to it. If someone picks it up meanwhile, it would be great.
@lalitb, Thank you for your answer, got it. As you've closed this as there needs a design change, are there any design documents to refer to?