opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Add bzlmod support

Open auzhva opened this issue 2 years ago • 6 comments

Since bazel 6.0, bazel added bzlmod dependency management and tracking system. Currently open telemetry is built by Bazel but is not published to the Bazel Central Regestry, which complicates importing open telemetry.

It would be awesome if open telemetry would be packaged to the BCR.

Is your feature request related to a problem? Opentelemetry imports dependencies with own opentelemetry_cpp_deps, which is not portable to bzlmod.

Describe the solution you'd like Create MODULE.bazel and publish to the BCR

Describe alternatives you've considered Continue using existing, but it's... Hard...

auzhva avatar Sep 27 '23 06:09 auzhva

@auzhva unfortunately we could not offer any official packaging.

esigo avatar Oct 09 '23 20:10 esigo

While this request makes sense, we (in opentelemetry-cpp) can not provide packaging for every build system.

The best way to address this is to make a contribution to the Bazel Central Registry directly.

marcalff avatar Oct 18 '23 19:10 marcalff

This issue is available for anyone to work on. Make sure to reference this issue in your pull request. :sparkles: Thank you for your contribution! :sparkles:

github-actions[bot] avatar Oct 19 '23 07:10 github-actions[bot]

Added help wanted to advertise.

Do not prepare a PR for opentelemetry-cpp, contribute to https://registry.bazel.build/ instead.

marcalff avatar Oct 19 '23 07:10 marcalff

This issue was marked as stale due to lack of activity.

github-actions[bot] avatar Dec 19 '23 01:12 github-actions[bot]

:wave: I submitted a PR for the modern bazel dependency management setup here:

I know there was some discussion above about submitting the config to the BCR (which I will do if this PR is merged), but my PR here is still required to modernize the bazel config in this repo.

We could also theoretically remove the old version of doing things in bazel, since right now there is some duplication, but I am initially leaving it in my PR to not affect users on older versions of bazel. I'm happy to remove it though and direct older bazel users to prior releases of this library instead if you'd prefer!

https://github.com/open-telemetry/opentelemetry-cpp/pull/2608

keith avatar Mar 25 '24 17:03 keith

This issue was marked as stale due to lack of activity.

github-actions[bot] avatar May 28 '24 01:05 github-actions[bot]

still valid, linked PR should be unblocked when my other prs land

keith avatar May 28 '24 18:05 keith