opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

[TRACE SDK] Batch Span Processor options not using environment variables

Open marcalff opened this issue 1 year ago • 2 comments

In this code:

struct BatchSpanProcessorOptions
{
  /**
   * The maximum buffer/queue size. After the size is reached, spans are
   * dropped.
   */
  size_t max_queue_size = 2048;

  /* The time interval between two consecutive exports. */
  std::chrono::milliseconds schedule_delay_millis = std::chrono::milliseconds(5000);

  /**
   * The maximum batch size of every export. It must be smaller or
   * equal to max_queue_size.
   */
  size_t max_export_batch_size = 512;
};

the default values for each configuration option are hard coded.

The specification requires to use the following environment variables:

  • OTEL_BSP_SCHEDULE_DELAY
  • OTEL_BSP_EXPORT_TIMEOUT
  • OTEL_BSP_MAX_QUEUE_SIZE
  • OTEL_BSP_MAX_EXPORT_BATCH_SIZE

Note that the export timeout option is also missing from BatchSpanProcessorOptions.

marcalff avatar Apr 05 '23 21:04 marcalff

This issue was marked as stale due to lack of activity.

github-actions[bot] avatar Jun 05 '23 02:06 github-actions[bot]

Is there any estimation on when this will be added?

oandreeva-nv avatar Jan 20 '24 00:01 oandreeva-nv