opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Inconsistency between Bazel & CMake

Open cngzhnp opened this issue 1 year ago • 2 comments

Describe your environment In OTLP project, there are two different build mechanisms which one of them could be used for compilation different targets. Also, it would be helpful to maintain different third party packages from their source codes.

Steps to reproduce For CMake, there is a file(third_party_release) which contains which third party library is linked with which version. Same for Bazel, the file(repository.bzl) contains same information. However, both file contains different third-party versions as an information.

For example;

  • benchmark=v1.5.3 was defined for CMake but for Bazel it was defined "benchmark-1.6.0".
  • CURL library was not defined as a depedency in the CMake.

What is the expected behavior? Same versions must be used for even different build mechanisms.

What is the actual behavior? There are different versions for Bazel and CMake which could cause inconsistency.

Additional context Add any other context about the problem here.

cngzhnp avatar Mar 27 '23 11:03 cngzhnp

CURL can be removed from bazel and benchmark should use the same version for both CMake and bazel.

esigo avatar Mar 27 '23 20:03 esigo

This issue was marked as stale due to lack of activity.

github-actions[bot] avatar May 27 '23 01:05 github-actions[bot]