opentelemetry-cpp-contrib icon indicating copy to clipboard operation
opentelemetry-cpp-contrib copied to clipboard

The version defined in fluentd CMakeLists not match the version in CHANGELOG

Open zurex opened this issue 11 months ago • 0 comments

Steps to reproduce

  • The version defined in fluentd CMakeLists is 1.1.2
    • https://github.com/open-telemetry/opentelemetry-cpp-contrib/blob/6a110537e2be97ab5ac397962941dde601a9c8dc/exporters/fluentd/CMakeLists.txt#L186
  • The version in CHANGELOG is [2.0.0] 2023-06-30
    • https://github.com/open-telemetry/opentelemetry-cpp-contrib/blob/6a110537e2be97ab5ac397962941dde601a9c8dc/exporters/fluentd/CHANGELOG.md?plain=1#L16

What is the expected behavior? set(OPENTELEMETRY_CPP_FLUENTD_VERSION "2.0.0")

What is the actual behavior? set(OPENTELEMETRY_CPP_FLUENTD_VERSION "1.1.2")

Additional context What's more, we should support versioned libs since opentelemetry-cpp has such behavior.

Could i raise a PR to address this issue?

zurex avatar Dec 10 '24 02:12 zurex