opentelemetry-cpp-contrib icon indicating copy to clipboard operation
opentelemetry-cpp-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add more Resource Attributes to the Otel-Webserver-Module Nginx instrumentation.

Open aryanishan1001 opened this issue 1 year ago • 2 comments

Some more resource attributes could be exported with the spans. Like request and response headers.

aryanishan1001 avatar Mar 26 '24 12:03 aryanishan1001

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: bryannaegele / name: Bryan Naegele (2f3debdfe91e21e960caf3344c0db369da09e75d)
  • :white_check_mark: login: elvanja / name: Vanja Radovanović (6a3ad343af8211706427f4deb17d1570ed87a9ff)

linux-foundation-easycla[bot] avatar Apr 10 '24 16:04 linux-foundation-easycla[bot]

This seems super useful to have on main. Is there some way in which external help (like, mine) could help get this merged and a new release tagged? As of writing this, without this PR a project with Phoenix 1.7.14, Bandit 1.5.5, and OpenTelemetry is broken.

erszcz avatar Jul 02 '24 09:07 erszcz

Hey. Is there any help needed here to merge this PR that we can do? We're not able to upgrade bandit because of this issue.

michelboaventura avatar Jul 16 '24 13:07 michelboaventura

Thank you for all this. Big help.

I will be merging this and #317 so I can knock out any remaining functionality changes needed and the new semcon. There will be some changes before the new release can be made so please consider everything WIP still.

bryannaegele avatar Jul 22 '24 20:07 bryannaegele