opentelemetry-cpp-contrib icon indicating copy to clipboard operation
opentelemetry-cpp-contrib copied to clipboard

otel-nginx: Can this module be used for openresty?

Open chrissam opened this issue 4 years ago • 6 comments

Just curious if this module can be used for openresty? If not is there any plan to include openresty in future release?

chrissam avatar Jun 16 '21 19:06 chrissam

Hi! This hasn't been tested in any way with OpenResty, but I assume the nginx span creation would still work. Regarding OpenResty support, do you mean accessing the tracing context (i.e. creating, modifying spans) in Lua blocks?

And OpenResty support is something that I've been wanting to add, just haven't got to it yet :)

seemk avatar Jun 17 '21 08:06 seemk

@seemk For now, the nginx span creation should be fine. But yes, would be cool to create and modify it inside lua blocks to get a more deeper insight.

chrissam avatar Jun 17 '21 10:06 chrissam

@seemk will this work on centos with OpenResty

kakireddyp avatar Jun 29 '21 17:06 kakireddyp

@seemk will this work on centos with OpenResty

It will work in the nginx case, but I haven't built it with OpenResty and/or CentOS yet.

seemk avatar Jul 13 '21 20:07 seemk

@seemk do you have any plans doing that?

kakireddyp avatar Jul 29 '21 13:07 kakireddyp

Hope it coming soon.

h1z3y3 avatar Apr 29 '22 09:04 h1z3y3