opentelemetry-cpp-contrib icon indicating copy to clipboard operation
opentelemetry-cpp-contrib copied to clipboard

Otel webserver samplers

Open starDigger opened this issue 1 year ago • 5 comments

Added 4 samplers to the otel-webserver-module: traceidratio, parentbased_always_on, parentbased_always_off, and parentbased_traceidratio. Added Conf file parameter for Sampler Ratio. Fixed README to correctly reflect what sampler options exist within the code base. Resolves #ticket_number 273 and closes out some //TODO's in main branch.

starDigger avatar Jan 26 '24 19:01 starDigger

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: starDigger / name: Bruce Peterson (49d9421a3ac205a33511e69c80d72cdd0ea406af, f6d868a8c102eec215aee6c12fee842a52420f9e, 700e8923b0043601ac0ec10f15a6379afe30412f, 6a3ec102491d5ea405573b338b23b3a3ac31b236)

Hello, this sampling feature for apache modules is in high demand, can we get a code review and a PR acceptance please?

robododge avatar Feb 29 '24 20:02 robododge

@DebajitDas @kpratyus Can someone help here?

lalitb avatar Feb 29 '24 21:02 lalitb

Hey @starDigger, the build were not triggered. Could you please re-push the code so that the builds can be triggered and we can merge it.

aryanishan1001 avatar Mar 12 '24 05:03 aryanishan1001

Hey, can you pull the code again and push your changes. Some builds were failing, so changes have been made to the build pipeline.

aryanishan1001 avatar Mar 19 '24 11:03 aryanishan1001