opentelemetry-cpp-contrib icon indicating copy to clipboard operation
opentelemetry-cpp-contrib copied to clipboard

Upgrade nginx instrumentation to support stable{1.22.0} and mainline{1.23.1} version.

Open DebajitDas opened this issue 3 years ago • 2 comments

Going forward, support for nginx instrumentation would only be supported on stable and mainline versions. With this PR, any new and old versions for nginx can be added or removed from "version.properties" file and compilation should work.

The generated nginx shared library would be located inside the compressed file. The directory has been modified from /opt/opentelemetry-webserver-sdk/WebServerModule/Nginx/ngx_http_opentelemetry_module.so ------> /opt/opentelemetry-webserver-sdk/WebServerModule/Nginx/{version}/ngx_http_opentelemetry_module.so

e.g /opt/opentelemetry-webserver-sdk/WebServerModule/Nginx/1.23.1/ngx_http_opentelemetry_module.so

DebajitDas avatar Aug 25 '22 09:08 DebajitDas

@DebajitDas When this pr can be merged?

fdiskbrain avatar Sep 19 '22 07:09 fdiskbrain

@DebajitDas When this pr can be merged?

@fdiskbrain This PR would be merged to "otel-webserver-module". Our internal QE is doing some regression test on this PR, once done, we will merge.

DebajitDas avatar Sep 19 '22 08:09 DebajitDas

any update here?

jarojasm95 avatar Oct 05 '22 15:10 jarojasm95

any update here?

Also eagerly waiting for it. 😸

shengyi-yan avatar Oct 10 '22 02:10 shengyi-yan

🎊 🙇 Thank you guys very much!

shengyi-yan avatar Oct 11 '22 06:10 shengyi-yan