opentelemetry-collector
opentelemetry-collector copied to clipboard
Updated public methods in configauth
Added context.Context to the following functions:
- GetClientAuthenticator
- GetServerAuthenticator Link to the issue: https://github.com/open-telemetry/opentelemetry-collector/issues/9808
Hello @TylerHelmuth, i just worked on it
thanks for the advice
Codecov Report
Attention: Patch coverage is 76.92308%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 92.45%. Comparing base (
c7c3401
) to head (cca7136
). Report is 29 commits behind head on main.
:exclamation: Current head cca7136 differs from pull request most recent head 0f77bfa
Please upload reports for the commit 0f77bfa to get more accurate results.
Files | Patch % | Lines |
---|---|---|
config/configauth/configauth.go | 40.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #9880 +/- ##
==========================================
- Coverage 92.59% 92.45% -0.14%
==========================================
Files 387 387
Lines 18198 18256 +58
==========================================
+ Hits 16850 16879 +29
- Misses 1007 1031 +24
- Partials 341 346 +5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I am having an error from codecov bot saying some lines of my code are missing coverage.
i checked what the issue was and it was because I did not write tests for the functions that are getting deprecated Is there anything I need to do? @TylerHelmuth
@AkhigbeEromo dont worry about that check for this PR
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
@AkhigbeEromo please handle merge conflicts
Okay @TylerHelmuth Will work on that
hope its good now ? @TylerHelmuth
This PR was marked stale due to lack of activity. It will be closed in 14 days.
Hello @jpkrohling, hope it is okay now?