opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Updated public methods in configauth

Open AkhigbeEromo opened this issue 10 months ago • 9 comments

Added context.Context to the following functions:

  • GetClientAuthenticator
  • GetServerAuthenticator Link to the issue: https://github.com/open-telemetry/opentelemetry-collector/issues/9808

AkhigbeEromo avatar Apr 02 '24 22:04 AkhigbeEromo

Hello @TylerHelmuth, i just worked on it

thanks for the advice

AkhigbeEromo avatar Apr 02 '24 22:04 AkhigbeEromo

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.45%. Comparing base (c7c3401) to head (cca7136). Report is 29 commits behind head on main.

:exclamation: Current head cca7136 differs from pull request most recent head 0f77bfa

Please upload reports for the commit 0f77bfa to get more accurate results.

Files Patch % Lines
config/configauth/configauth.go 40.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9880      +/-   ##
==========================================
- Coverage   92.59%   92.45%   -0.14%     
==========================================
  Files         387      387              
  Lines       18198    18256      +58     
==========================================
+ Hits        16850    16879      +29     
- Misses       1007     1031      +24     
- Partials      341      346       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 02 '24 22:04 codecov[bot]

I am having an error from codecov bot saying some lines of my code are missing coverage.

i checked what the issue was and it was because I did not write tests for the functions that are getting deprecated Is there anything I need to do? @TylerHelmuth

AkhigbeEromo avatar Apr 03 '24 14:04 AkhigbeEromo

@AkhigbeEromo dont worry about that check for this PR

TylerHelmuth avatar Apr 03 '24 19:04 TylerHelmuth

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Apr 18 '24 03:04 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar May 08 '24 03:05 github-actions[bot]

@AkhigbeEromo please handle merge conflicts

TylerHelmuth avatar May 09 '24 16:05 TylerHelmuth

Okay @TylerHelmuth Will work on that

AkhigbeEromo avatar May 10 '24 10:05 AkhigbeEromo

hope its good now ? @TylerHelmuth

AkhigbeEromo avatar May 10 '24 11:05 AkhigbeEromo

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar May 25 '24 03:05 github-actions[bot]

Hello @jpkrohling, hope it is okay now?

AkhigbeEromo avatar May 28 '24 16:05 AkhigbeEromo