opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[configtls] Rename config structs for consistancy

Open arjunmahishi opened this issue 1 year ago • 2 comments

Description: <Describe what has changed.>

Simply renames a few structs in the configtls package for consistence.

TLSClientSetting to ClientConfig TLSServerSetting to ServerConfig TLSSetting to Config

Link to tracking Issue: <Issue number if applicable>

Fixes #9474

arjunmahishi avatar Feb 06 '24 19:02 arjunmahishi

I just ran this:

 rg "TLSClientSetting" -l --type go | xargs -I{} sh -c "gsed -i 's/TLSClientSetting/ClientConfig/g' {}"
 rg "TLSServerSetting" -l --type go | xargs -I{} sh -c "gsed -i 's/TLSServerSetting/ServerConfig/g' {}"
 rg "TLSSetting" -l --type go | xargs -I{} sh -c "gsed -i 's/TLSSetting/Config/g' {}"

Will take care of any tests that fail (not expecting anything to fail though).

arjunmahishi avatar Feb 06 '24 19:02 arjunmahishi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.89%. Comparing base (b808e85) to head (848514f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9495   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files         347      347           
  Lines       18324    18324           
=======================================
  Hits        16655    16655           
  Misses       1344     1344           
  Partials      325      325           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 20:02 codecov[bot]

Can this be merged? or am I missing a step?

arjunmahishi avatar Feb 15 '24 19:02 arjunmahishi

@arjunmahishi please take a look at the conflict.

TylerHelmuth avatar Feb 28 '24 02:02 TylerHelmuth

@arjunmahishi please take a look at the conflict.

Done

arjunmahishi avatar Feb 28 '24 03:02 arjunmahishi