opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[configcompression] Use if instead of switch on UnmarshalText

Open mx-psi opened this issue 1 year ago • 3 comments

          nit: Sorry, but my mind goes crazy when I see a switch used like an if :)) Can we fix this probably in a separate PR :)

Originally posted by @bogdandrutu in https://github.com/open-telemetry/opentelemetry-collector/pull/9416#discussion_r1474920110

mx-psi avatar Feb 05 '24 12:02 mx-psi

I guess ideally we would have a linter for this

mx-psi avatar Feb 05 '24 12:02 mx-psi

I don't think this is needed for 1.0 since it is an internal implementation detail, I am removing from the milestone

mx-psi avatar Feb 12 '24 16:02 mx-psi

I agree that this is not required for a 1.0 release.

TylerHelmuth avatar Feb 12 '24 21:02 TylerHelmuth

Hello @TylerHelmuth @mx-psi , i would like to work on this issue

AkhigbeEromo avatar Mar 23 '24 22:03 AkhigbeEromo