opentelemetry-collector
opentelemetry-collector copied to clipboard
[confmap] Return error when decoding negative values into uints
Description: This adds a decode hook for unmarshalling negative integers into uint types. This will now return an error instead of converting negative values into large uint values.
Link to tracking Issue: <Issue number if applicable> Fixes #9060
Testing: Added unit tests for confmap functionality, functional tests in memory limiter processor (the original component this issue was filed against)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.77%. Comparing base (
05ceb20
) to head (54a3d4d
). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9169 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 359 359
Lines 16631 16637 +6
=======================================
+ Hits 15263 15269 +6
Misses 1041 1041
Partials 327 327
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
I believe this is ready to be merged.
@bogdandrutu Do you have any concerns here?
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This comes from #9532. Can we add a note to remove the hook once we disable
WeaklyTypedInput
?
Done. I've added a TODO referencing the issue. 👍