opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Stabilize module confignet

Open codeboten opened this issue 1 year ago • 12 comments

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases:

  • [x] No open issues or PRs in the module that would require breaking changes
  • [x] No TODOs in the module code that would require breaking changes
  • [x] No deprecated symbols in the module
  • [x] No symbols marked as experimental in the module
  • [x] The module follows the Coding guidelines

Please also make sure to publicly announce our intent to stabilize the module on:

  • [x] The #otel-collector CNCF Slack Channel
  • [x] The #opentelemetry CNCF Slack channel
  • [x] A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

codeboten avatar Dec 05 '23 15:12 codeboten

This is the PR to mark confignet as stable https://github.com/open-telemetry/opentelemetry-collector/pull/7954

codeboten avatar Dec 07 '23 19:12 codeboten

Open issues regarding confignet:

  • [x] https://github.com/open-telemetry/opentelemetry-collector/issues/4331

codeboten avatar Dec 07 '23 20:12 codeboten

I think we should have 1.0 milestones for each module that we want to release as 1.0 so we can include all the issues there

dmitryax avatar Dec 07 '23 21:12 dmitryax

@dmitryax created the milestone and added issues to it

codeboten avatar Dec 07 '23 21:12 codeboten

@codeboten I think it would be helpful to have links as in #8978 so that right before marking as 1.0 one can quickly check that we did not accidentally introduce any new TODOs or experimental symbols

mx-psi avatar Dec 15 '23 10:12 mx-psi

We need to address the new comments in https://github.com/open-telemetry/opentelemetry-collector/pull/7954 as well.

atoulme avatar Dec 19 '23 18:12 atoulme

Filed #9159 to add this to coding guidelines

mx-psi avatar Dec 20 '23 12:12 mx-psi

I see the comments in #7954 have been acted upon with #9105 - can we move to announce stabilization intent, anything else left to consider?

atoulme avatar Jan 10 '24 04:01 atoulme

Should we remove Context from the method names? (That is, effectively just add context.Context to the original methods?)

mx-psi avatar Jan 10 '24 09:01 mx-psi

Should we remove Context from the method names? (That is, effectively just add context.Context to the original methods?)

We discussed this offline and decided that we should

mx-psi avatar Jan 10 '24 16:01 mx-psi

See https://github.com/open-telemetry/opentelemetry-collector/pull/9258

codeboten avatar Jan 10 '24 17:01 codeboten

Blocked by the stabilization work for confmap

codeboten avatar Apr 17 '24 18:04 codeboten

Is this now unblocked since confmap was just declared stable?

atoulme avatar Aug 28 '24 06:08 atoulme