opentelemetry-collector
opentelemetry-collector copied to clipboard
Manually report status for core exporters
Description: This is a PR is an alternative to #8684. It adds manual status reporting to the otlp, otlphttp, and debug exporters. Reviewers, please compare with #8684 and weigh in on what approach you prefer, and/or additional suggestions.
Link to tracking Issue: #7682
Testing: Units, manual.
Codecov Report
Attention: Patch coverage is 94.25287% with 5 lines in your changes are missing coverage. Please review.
Project coverage is 90.27%. Comparing base (
946dc24) to head (9772f45). Report is 292 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| exporter/otlphttpexporter/otlp.go | 87.50% | 5 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #8788 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 343 343
Lines 18003 18069 +66
=======================================
+ Hits 16252 16312 +60
- Misses 1424 1429 +5
- Partials 327 328 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If I were only reporting status for exporters, I would choose #8684 because it introduces a flexible opt-in approach that reduces the overall amount of code that needs to be written. My only reservation is that that approach wouldn't apply fully to other component types. We could add similar WithStatusReporting options to the processorhelper and receiverhelper, but they would likely only allow you to wrap start. Receivers are not consumers. While processors are consumers, they are in the middle of a pipeline, and errors returned from consume do not necessarily belong to the processor and might be propagated from further down the pipeline. That is to say, status reporting for receivers and processors will be more manual, so it might make sense to do things manually for exporters so they aren't a special case.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
Closed as inactive. Feel free to reopen if this PR is still being worked on.