opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

exporter/loggingexporter.Config.LogLevel has different behavior after #5677

Open bogdandrutu opened this issue 2 years ago • 2 comments

After https://github.com/open-telemetry/opentelemetry-collector/pull/5677 was merged, we no longer use LogLevel the way was before (where we set it for zap.Core).

We need to look into what that configuration does right now, if we need to deprecate/rename/re-describe or what we need to do.

bogdandrutu avatar Aug 09 '22 20:08 bogdandrutu

The new behavior or the log level option is described on this comment https://github.com/open-telemetry/opentelemetry-collector/pull/5677#pullrequestreview-1036046290.

We have only ever used debug and info levels, and I doubt we would use warn or error here. Some possible renames:

  • verbosityor verbosity_level (either keeping info and debug or maybe with brief and detailed values)
  • verbose, detailed or show_payload_contents (boolean flag, defaults to false)

@bogdandrutu (and also @tigrannajaryan ) Do you prefer any particular option among those?

mx-psi avatar Aug 10 '22 07:08 mx-psi

I think I like the "verbosity" level. The reason is that, it may allow us to add new levels if needed in the future. Also look into https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configtelemetry/configtelemetry.go#L26 may use that?

bogdandrutu avatar Aug 10 '22 17:08 bogdandrutu

Take a look at #6334

mx-psi avatar Oct 17 '22 10:10 mx-psi

Fixed by #6334

mx-psi avatar May 04 '23 11:05 mx-psi