opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Update the changelog procedure to match contrib

Open codeboten opened this issue 2 years ago • 8 comments

The contrib repo has updated its changelog procedure to reduce friction for PRs / users. This issue is an open question whether or not the core repo should follow the same process.

This would ensure users contributing to both repos have a consistent experience and makes the release process consistent as well.

codeboten avatar Jul 07 '22 18:07 codeboten

I think we should have the same process. The only 'odd' thing in my mind is that the tooling code lives in contrib, if we use it here it may make more sense to move it to somewhere like https://github.com/open-telemetry/opentelemetry-go-build-tools

mx-psi avatar Jul 08 '22 08:07 mx-psi

@mx-psi i was thinking the same, i'll get the code moved to the tools repo.

codeboten avatar Jul 13 '22 18:07 codeboten

@mx-psi see https://github.com/open-telemetry/opentelemetry-go-build-tools/pull/121

codeboten avatar Jul 20 '22 15:07 codeboten

Does it worth the complicated process since we don't have the conflict problem in this repo?

bogdandrutu avatar Aug 19 '22 13:08 bogdandrutu

I'm a fan of having consistent tooling across repos to reduce the amount of work needed at release time. This could help with release automation.

That being said you're right that the conflict that chloggen alleviates isn't a problem in this repo. I defer to other maintainers/approvers to go one way or the other here.

codeboten avatar Sep 13 '22 21:09 codeboten

I also think being consistent is important. I don't feel like this complicates much the process of adding a changelog entry, but maybe there is some issue I am not aware of?

mx-psi avatar Sep 14 '22 11:09 mx-psi

I also prefer having the changelog generator here.

jpkrohling avatar Sep 14 '22 13:09 jpkrohling

It can also help us avoid easy mistakes like adding the changelog entry to the wrong part of the changelog document. For example #6052 change is added to 0.59.0. Currently it's easy to make that mistake, specially if you are rebasing the PR

mx-psi avatar Sep 15 '22 13:09 mx-psi