opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[batchprocessor] Modernize the batch processor

Open jmacd opened this issue 4 months ago • 7 comments

Description

Implements batchprocessor using exporterhelper features. Behind two feature flags:

  • processor.batch.useExporterHelper: use the new logic, QueueBatch with BlockOnOverflow
  • processor.batch.propagateErrors: use error propagation via WaitForResult

Currently, this emits metrics with incorrect names; the batch processor emits metrics like an exporter, see #14038.

Link to tracking issue

Fixes #13582 Part of #13766 Part of #14038

Testing

Yes.

For every existing test case (19 cases), the test is run once with the feature and once without the feature. For a few selected tests, the propagateErrors feature is also tested.

4 tests are disabled in the exporterhelper-based mode because of the incorrect metric names.

Documentation

jmacd avatar Aug 06 '25 23:08 jmacd

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Sep 03 '25 03:09 github-actions[bot]

Blocked by #13478

jmacd avatar Sep 03 '25 15:09 jmacd

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Oct 11 '25 03:10 github-actions[bot]

Codecov Report

:x: Patch coverage is 97.41379% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 91.63%. Comparing base (ba6cd70) to head (2174afc). :warning: Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
processor/batchprocessor/config.go 25.00% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #13583    +/-   ##
========================================
  Coverage   91.62%   91.63%            
========================================
  Files         655      656     +1     
  Lines       42729    42835   +106     
========================================
+ Hits        39151    39252   +101     
- Misses       2758     2761     +3     
- Partials      820      822     +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 15 '25 18:10 codecov[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Nov 12 '25 03:11 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Nov 28 '25 03:11 github-actions[bot]