opentelemetry-collector-releases icon indicating copy to clipboard operation
opentelemetry-collector-releases copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

RPM packages are missing a /bin/sh dependency

Open shawnbutts opened this issue 2 years ago • 4 comments

/bin/sh is required for the postinstall.sh and other scripts.

Adding a Requires: for all dependencies needed during install is a common standard.

shawnbutts avatar Nov 29 '22 19:11 shawnbutts

Can you give more details about it? Is this happening for specific versions of specific distributions? I believe I installed the RPM a few times, and I'm confident it worked on Fedora 36.

jpkrohling avatar Nov 29 '22 20:11 jpkrohling

It most likely works in your testing because, the /bin/sh dependency is already in place. But, in an environment where it is not yet there (kickstart, etc) the install will fail in the PREIN step.

If there requirement is explicitly included, then RPM resolver can order the package installs correctly.

shawnbutts avatar Nov 29 '22 20:11 shawnbutts

Makes total sense. Are you able to open a PR fixing it? It's very likely here:

https://github.com/open-telemetry/opentelemetry-collector-releases/blob/26c3f343e63513b7b34b2765eda5ab336d0146c9/cmd/goreleaser/internal/configure.go#L106-L139

Here's the relevant documentation from goreleaser: https://goreleaser.com/customization/nfpm/

jpkrohling avatar Nov 29 '22 20:11 jpkrohling

Sorry, I'm not familiar enough with the project or GoReleaser to do a PR at the moment.

shawnbutts avatar Nov 29 '22 20:11 shawnbutts