opentelemetry-collector-releases icon indicating copy to clipboard operation
opentelemetry-collector-releases copied to clipboard

add linux-arm builds to releaser

Open blumamir opened this issue 3 years ago • 4 comments
trafficstars

Fixes #105 . More context and discussions can be read in the issue.

This adds linux-arm builds to the collector and collector contrib, so they can be published to docker hub and consumed on raspberry pi which is running armv7.

This PR follows another PR for adding this architecture to the CI testing in collector repo here. For contrib, this architecture is also tested in CI here

I added the support by following the way it is done for other os-arch, so please review thoroughly as I have little experience with these tools.

Again, thank you @mx-psi for pointing me to the right places :)

blumamir avatar Jun 04 '22 06:06 blumamir

CI fails with:

format=rpm package=otelcol-contrib
   •calculating checksums
   •docker images
      • building docker image    image=otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-arm
      • building docker image    image=otel/opentelemetry-collector:0.52.0-SNAPSHOT-6eeeed8-arm
      • building docker image    image=otel/opentelemetry-collector:0.52.0-SNAPSHOT-6eeeed8-386
      • building docker image    image=otel/opentelemetry-collector:0.52.0-SNAPSHOT-6eeeed8-amd64
      • building docker image    image=otel/opentelemetry-collector:0.52.0-SNAPSHOT-6eeeed8-arm64
      • building docker image    image=otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-386
      • building docker image    image=otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-amd64
      • building docker image    image=otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-arm64
   ⨯release failed after 2054.19serror=docker build failed: failed to build otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-arm: exit status 1: #1 [internal] load build definition from Dockerfile

Any tips on how to debug this issue?

blumamir avatar Jun 04 '22 09:06 blumamir

Can you add --debug here? https://github.com/open-telemetry/opentelemetry-collector-releases/blob/b26b0be133c006379069dc9025bdf15122249b2d/.github/workflows/ci-goreleaser.yaml#L47

It's hard to know what is happening with the current output

mx-psi avatar Jun 07 '22 15:06 mx-psi

On a Linux machine (and presumably others, like Mac), you can run "goreleaser" locally, which would produce better output and log files. Let me know if you can't figure out how to do it following goreleaser's documentation (and this repo's).

jpkrohling avatar Jul 04 '22 20:07 jpkrohling

Modifying the QEMU setup will probably fix the issue (see #173)

mx-psi avatar Aug 03 '22 13:08 mx-psi

What's the best way to make progress here? @blumamir do you plan on continuing or should someone else carry on? Seems like @mx-psi 's suggestion is an easy one to try.

fidesachates avatar Mar 26 '23 21:03 fidesachates

Hey @blumamir are you looking to finish this pull request? I'm also interested in otel-contrib release for armv7.

I think for --platform argument, it should be linux/arm/v7 as that's what we have been using to build docker image for the raspberry pi.

Wal8800 avatar May 17 '23 23:05 Wal8800

Closing in favor of #349

mx-psi avatar Jul 21 '23 09:07 mx-psi