opentelemetry-collector-contrib
opentelemetry-collector-contrib copied to clipboard
fix(s3exporter/config-validation): endpoint should contain region and S3 bucket
Description:
Addresses issue #32774. Discussion: https://github.com/open-telemetry/opentelemetry-collector-contrib/discussions/32766.
Still a draft.
Link to tracking Issue: #32774
Testing: added test cases to validate config when endpoint is provided.
Documentation: TBD
Configuration logic (to be reviewed):
- An endpoint is provided, and Region still needs to be provided (as per the AWS SDK Go config, even though the region can be included in the endpoint itself). The S3 bucket name is optional.
- An endpoint is not provided, thus region and S3 bucket name should be provided (return an error for each if one of those 2 isn't)
Tasks:
- [ ] Add entry to changelog
- [x] Edit the docs?
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: dabcoder / name: David B. (b29567ca38c68e26b14f95d0bc2c766c57ac04a0, 853d91611baa3f8190ef00b9ba1f6aec67196db4, acf7ce216fed8b4bedb79973d2c9a2e484c96518, 3d95e5a162a2732f766923a6d977a6ba5c3f621e, df9b2a0d2213fd269d55053d1ce2a53bc010f386, c79f3750ad9639a56b8f77df2fa1ec57b16c2370, fa5ca3fa494fe279609751338da2da21ae98a60e, 138679459d255abab6d965275366bc2c1fde0cff, e7c0a6acdbb0fa8c19c8244a7ef3ee40a4d47599, 5a23120ccee51aaa96f025c667d2d2bb7c8498fd, 7b60ae7e027de11b78c43d49db528949adb9ecba, b3f2f61e1cb4860cddae9462fc7e6c813cbb6b5c, 362a623825387ee92f13990fd524a4356f93b49e)
Actually I am not sure what protocol endpoint
should use. I am seeing unsupported protocol scheme \"s3\""}
errors in logs when using an endpoint starting with s3://
, so we may also need to clarify that this support http(s)
only?
cc @atoulme @pdelewski.
Actually I am not sure what protocol
endpoint
should use. I am seeingunsupported protocol scheme \"s3\""}
errors in logs when using an endpoint starting withs3://
, so we may also need to clarify that this supporthttp(s)
only?
Yes, I guess so.
@bogdandrutu anything else I should do in order to merge this?
This PR was marked stale due to lack of activity. It will be closed in 14 days.
@open-telemetry/collector-contrib-maintainer if anyone has a chance to take another look at this PR before it gets marked as stale again, that'd be great, thanks.
@dabcoder PTAL at the failing tests
Thanks @dmitryax. They should be fixed now, I ran the tests locally and they're passing.