opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

[extension/prometheusapiserverextension] feat: implement Prometheus API extension

Open gracewehner opened this issue 1 year ago • 2 comments

Description: Add Prometheus API as an extension for debugging purposes to be able to see the targets, config, and service discovery for what the prometheus receiver is scraping. This uses the Prometheus API packages in order to duplicate less code. It follows the same design to host the server as the Prometheus UI web handler.

Link to tracking Issue: Issue: https://github.com/open-telemetry/wg-prometheus/issues/63 Relevant PR discussions:

  • https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/29622
  • https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/23244

Testing: Ran an otelcollector with prometheusreceiver and extension. Added tests to ensure all expected paths in the API are working and all go routines are cleaned up

Documentation: Added to READMEs for extension and prometheusreceiver

gracewehner avatar Apr 23 '24 17:04 gracewehner

Thanks @Aneurysm9 and @dashpole, I have made the changes we discussed. Please let me know if I should revert this back to all being inside the prometheus receiver.

This PR is also dependent on https://github.com/prometheus/prometheus/pull/13932 to be merged first.

gracewehner avatar May 07 '24 23:05 gracewehner

Please let me know if I should revert this back to all being inside the prometheus receiver.

I think that is what we had decided in the last meeting, right?

dashpole avatar May 08 '24 15:05 dashpole

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar May 23 '24 05:05 github-actions[bot]

Looks like the promethues PR linked above was merged. Do we need to wait for a release of prometheus/prometheus?

dashpole avatar May 23 '24 13:05 dashpole

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Jun 07 '24 05:06 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Jun 22 '24 05:06 github-actions[bot]