opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

Azure Event Hub receiver Semantic Convention translator

Open ThatRendle opened this issue 10 months ago • 13 comments

Description:

This PR changes the translator used by the Azure Event Hubs receiver to change property names on log records and metrics to the equivalent OTel Semantic Conventions names, making it easier to query logs and metrics ingested in this way alongside other logs and metrics.

Testing: WIP.

Documentation: WIP

ThatRendle avatar Apr 17 '24 15:04 ThatRendle

I like this idea and I think it makes a lot of sense to try to map to Semantic Conventions were possible. Can you make sure an Issue is created to track this against?

cparkins avatar Apr 18 '24 18:04 cparkins

Can you please also contribute those transformations to https://github.com/open-telemetry/semantic-conventions so we have it in the spec?

atoulme avatar Apr 24 '24 02:04 atoulme

Going along with @atoulme's request, I think it may be good to block this PR until the suggested conventions here have been approved and merged into the semantic conventions repo, as any changes requested there will need to be reflected in this package (and PR). The problem with going forward with this PR before semantic conventions are finalized, would be the decisions there could end up being breaking changes here (if this gets merged and released).

Let me know if I've misunderstood the nature of this change though 👍

crobert-1 avatar Apr 30 '24 15:04 crobert-1

@atoulme @crobert-1 @cparkins I will get a semconv issue/PR opened to add the net-new attribute names. As for the mapping of azure fields to existing fields, I do not believe the semantic convention currently defines those. The closest I know about is are these appendices . I will open a issue/PR for that as well.

TylerHelmuth avatar Apr 30 '24 18:04 TylerHelmuth

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar May 21 '24 05:05 github-actions[bot]

This is still a WIP. The work to add semmantic conventions for the new azure namespace is on going.

MikeGoldsmith avatar May 21 '24 07:05 MikeGoldsmith

Is it worth converting this PR to draft until it is ready for review?

MovieStoreGuy avatar May 22 '24 01:05 MovieStoreGuy