opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

OpenTelemetry Protocol with Apache Arrow Exporter component

Open jmacd opened this issue 1 year ago • 5 comments

Description:

This is the same code as OTel-Arrow at https://github.com/open-telemetry/otel-arrow/releases/tag/v0.23.0 (plus lint fixes). Only import statements change here, to match the host repository.

Link to tracking Issue: #26491

Testing: Test coverage is approximately 90%.

Documentation: I double-checked and the existing README had only a few updates needed.

jmacd avatar Mar 26 '24 23:03 jmacd

The component will need a metadata.yaml file.

andrzej-stencel avatar Apr 10 '24 10:04 andrzej-stencel

I will re-open this.

jmacd avatar Apr 12 '24 18:04 jmacd

Same as https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32015#issuecomment-2073301725

jmacd avatar Apr 23 '24 19:04 jmacd

Reviewers cc/ @dmitryax @andrzej-stencel, the corresponding Receiver component has merged. We believe that this code, copied from https://github.com/open-telemetry/otel-arrow/releases/tag/v0.22.0, has already received sufficient review.

jmacd avatar Apr 24 '24 20:04 jmacd

Sorry, I don't have a chance to review this at this point. @codeboten, I added you as a reviewer, as requested by Josh, given that you helped with the receiver part.

dmitryax avatar May 01 '24 16:05 dmitryax

@codeboten All generated tests have been re-enabled, I wasn't aware of that mechanism. Nice.

jmacd avatar May 10 '24 20:05 jmacd

Since this component is in development stability, I'm happy to merge this request and have the above remarks resolved in separate pull requests, if needed.

andrzej-stencel avatar May 13 '24 07:05 andrzej-stencel