opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

collectd receiver is not writing anything to debug log on start

Open cforce opened this issue 4 months ago • 11 comments

Component(s)

receiver/collectd

Is your feature request related to a problem? Please describe.

When debugging if collectd is properly configured and loading i would epect an logs in debug level.

Describe the solution you'd like

Collectd shall report as loaded receiver plugin and on what host and port it is serving

Describe alternatives you've considered

No response

Additional context

No response

cforce avatar Mar 05 '24 14:03 cforce

Pinging code owners:

  • receiver/collectd: @atoulme

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] avatar Mar 05 '24 14:03 github-actions[bot]

Sounds like a valid enhancement to me. I did a quick scan of the receiver and didn't see any log messages that describe this information. Removing needs triage.

crobert-1 avatar Mar 05 '24 16:03 crobert-1

Sure, would you like to offer a patch?

atoulme avatar Mar 06 '24 00:03 atoulme

@atoulme @crobert-1 Can I take this up ?

kernelpanic77 avatar Mar 12 '24 17:03 kernelpanic77

@atoulme @crobert-1 Can we discuss this issue in the weekly SIG ?

kernelpanic77 avatar Mar 19 '24 17:03 kernelpanic77

Do you have a specific question or problem you're wanting to discuss?

crobert-1 avatar Mar 19 '24 18:03 crobert-1

@crobert-1 I am a bit unsure if understood the problem correctly. From what I understood only the ServeHTTP method of the collectdReceiver struct has to be changed to add the debug logs for Host and Port.

Collectd shall report as loaded receiver plugin

Also, @atoulme @crobert-1 Could you also explain this requirement in a little more detail ?

kernelpanic77 avatar Mar 20 '24 16:03 kernelpanic77

FWIW you can always come to a SIG meeting and ask any question. In this instance, it feels like something we can resolve over Github.

Yes, I believe you are correct, just need to add a bit of logging in that method.

atoulme avatar Mar 20 '24 16:03 atoulme

FWIW you can always come to a SIG meeting

Sure @atoulme

Collectd shall report as loaded receiver plugin

I am not sure if I understood this sentence correctly. Could you explain this part ?

kernelpanic77 avatar Mar 20 '24 16:03 kernelpanic77

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • receiver/collectd: @atoulme

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] avatar May 20 '24 03:05 github-actions[bot]

I am not sure if I understood this sentence correctly. Could you explain this part ?

Just that the receiver started ok. As in, it reports in debug in the Start method that it started.

atoulme avatar May 20 '24 22:05 atoulme