opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Indexer metrics ep2 for splunkenterprisereceiver

Open greatestusername opened this issue 1 year ago • 6 comments

Description: Adds additional indexer metrics to Splunk Enterprise receiver obtained from ad-hoc searches against Indexer or Cluster Manager instances.

Disables by default API endpoint searches that only return results for the specific instance which is having its API called. These can be re-enabled in config if those metrics are specifically required.

Generated tests and docs for these additional metrics

Link to tracking Issue: 30704

Testing: Tests generated with mdatagen

Documentation: Documentation generated with mdatagen

greatestusername avatar Jan 24 '24 17:01 greatestusername

Good stuff! Just some nits on metrics. I didn't check the scraper changes yet.

atoulme avatar Jan 25 '24 08:01 atoulme

@MovieStoreGuy this should cover most all of the indexer metrics for this phase. Let me know if you notice anything required after you've given the PR a look? Thanks!

greatestusername avatar Jan 31 '24 13:01 greatestusername

2 failures outside of my control in current tests:

--- FAIL: TestGetNewToken (0.01s)
    --- FAIL: TestGetNewToken/Bad_payload_returned (0.01s)
        testing.go:1465: race detected during execution of test
    testing.go:1465: race detected during execution of test
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/bigipreceiver	0.303s
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/bigipreceiver/internal/mocks	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/bigipreceiver/internal/models	[no test files]
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/bigipreceiver/internal/metadata	1.098s
FAIL

Wil re-run on next base mergeupdate

greatestusername avatar Feb 07 '24 15:02 greatestusername

le sigh :D

2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60516: remote error: tls: bad certificate
2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60518: remote error: tls: bad certificate
2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60534: remote error: tls: bad certificate
2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60544: remote error: tls: bad certificate
2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60554: write tcp 127.0.0.1:43767->127.0.0.1:60554: use of closed network connection
FAIL
	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter	coverage: 88.4% of statements
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter	8.832s

greatestusername avatar Feb 08 '24 15:02 greatestusername

one more time!

[2024-02-08T16:19:29.200Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure
[2024-02-08T16:19:29.200Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure
    at main (/snapshot/repo/dist/src/index.js)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

greatestusername avatar Feb 08 '24 16:02 greatestusername

@jpkrohling or @TylerHelmuth anything else I need to do on this PR? Let me know! Thanks!

greatestusername avatar Feb 09 '24 14:02 greatestusername