opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

[exporter/awss3] add marsheler config to pick only body content of logs

Open anthoai97 opened this issue 1 year ago • 10 comments

Description: <Describe what has changed.>

This pull request introduces a new marshaller for the awss3 exporter. It disregards resources, labels, and selectively extracts only the body content of the logs, facilitating simplified AWS Athena connection and querying. While straightforward, this enhancement accommodates various use cases, enabling the extraction of specific logs for statistical analysis and long-term archival reporting.

Example when write only body to S3:

EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr
EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr
EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr
EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr

Testing: <Describe what testing was performed and which tests were added.> Work as expected when used Athena to Query: athena

Documentation: <Describe the documentation added.> Readme updated.

anthoai97 avatar Jan 06 '24 14:01 anthoai97

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: anthoai97 / name: An Quách (6a1cdc50da2e02d0e025d91b845967c03d7cfc3f)

Please rebase

atoulme avatar Jan 06 '24 17:01 atoulme

Please rebase

@atoulme i'm rebased, thank you !!!

anthoai97 avatar Jan 06 '24 18:01 anthoai97

Thank you, this looks good. A last nit on the changelog note and I am ready to accept the PR.

atoulme avatar Jan 10 '24 22:01 atoulme

Thank you, this looks good. A last nit on the changelog note and I am ready to accept the PR.

I'm pleased to hear that. I updated the changelog and changed the variable name to pass the lint workflow. Thank you.

anthoai97 avatar Jan 11 '24 03:01 anthoai97

Hi @atoulme, could you please guide the steps I need to take to merge into the 'main' branch? Are there any specific requirements or actions I should be aware of?

anthoai97 avatar Jan 14 '24 08:01 anthoai97

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Jan 29 '24 05:01 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Feb 12 '24 05:02 github-actions[bot]

Sorry, please rebase and I can flag for maintainers to take a look.

atoulme avatar Feb 12 '24 05:02 atoulme

Dear @atoulme, I have rebased the branch, but unfortunately, I made a mistake during the process which added many reviewers to the review list. Could you please advise me on how to resolve this issue?

Thank you very much !!!

anthoai97 avatar Feb 12 '24 15:02 anthoai97